The Signpost

Technology report

What Git means for end users, design controversies and pertinent poll results

Git: the state of play

Developer and Git switchover manager Chad Horohoe presenting last year in New Orleans

Recently "Technology reports" have abounded with different stories arising from the Git switchover on March 21; it can be easy to miss the wood for the trees when negotiating one of the largest changes to their workflows developers have experienced in years. To assist in establishing the current "state of play" when it comes to the switchover, the Signpost caught up with Chad Horohoe, the WMF developer responsible for managing the switchover.

Chad, are you happy with how things have gone so far? Would you have done anything differently, and if so what?

So far, I think the migration has gone well. There's still a learning curve that people are trying to get past. As far as what I'd do differently if I had to do this whole process again, I would have been much more aggressive in recruiting guinea pigs to help me test our new system. The biggest complaint I have seen from users so far have been related to learning Gerrit and overcoming the Git learning curve I mentioned. Getting people involved in testing the process at an earlier point would've made this easier. Also, given some of the reservations with Gerrit, I think having people involved earlier would've helped us discover these issues sooner.

The move to Git has probably sounded rather abstract to many Wikimedians. What can they expect in the way of tangible differences?

The most important part of this process has been changing our commit workflow to a "pre-commit review" model. The MediaWiki codebase and its extensions have to be runnable at all times—we shouldn't break things when we can avoid it. So by changing our review model, we are trying to accomplish two big things:
  • We're trying to lower the bar to contribution. Since the review process now keeps the codebase clean of things that aren't quite ready for production, we're trying to encourage a lot more casual contributors who maybe didn't have the level of skill that we'd look for when granting commit access (the ability to modify core MediaWiki code). As of this week, everyone's code is reviewed beforehand, so we're trying to level the playing field for everyone who wants to write code (whether it's a one-line fix or a huge new feature).
  • By keeping the code more stable, we're trying to reduce the time it takes to release MediaWiki to our primary users—WMF wikis. Our targeted goal is currently deploying the latest reviewed code every 2 weeks. This encourages contributors who like seeing their work live on the sites, as well as gets fixes and new features in the users' hands much faster.

Technology Reports since "Git day" have included coverage of some of the issues that have arisen since the switchover. How confident are you that once developers get used to the new way of working, those concerns will be resolved?

I think there's two types of issues that have arisen from the changes. The first are "Git issues". These are all problems stemming from the fact that we're trying to teach people how to use a radically different tool from the past. Git has a learning curve, but I think we're starting to get more people over that hump and used to some of the day-to-day work. The second set of issues people are having are "Gerrit issues". Gerrit is not a perfect tool and there are some rough edges to work out. While I will be looking at the work Daniel Friesen and others put into alternative code review tools, I must say that I disagree with the assertion that Gerrit is fundamentally flawed. I've found the Gerrit development community to be active and responsive so I believe some of the more pressing bugs we've uncovered will be fixed for us. Overall, I think that these concerns will resolve over time as people get used to the new system and some of the more glaring issues are fixed.

Is it possible to avoid controversy when changing a design?

Changing the Wikipedia "puzzle globe" logo in May 2010 drew a similar amount of controversy as this month's diff colour update.

In 1957, C. Northcote Parkinson bemoaned the fact that getting agreement on the design for a new bikeshed is uniformly more difficult than getting agreement on the design of a nuclear reactor; though fewer people are affected, the entire community (in Parkinson's case a committee) are willing and able to give their opinion on the matter. MediaWiki tries to avoid this problem by allowing logged-in users to choose how they wish the proverbial bikeshed to appear to them, but it is often not enough: participants still argue over how interface elements should appear to the overwhelming majority of users who are not logged in.

Such was the situation this week as the English Wikipedia's Technical Village Pump became a forum for discussing the changes to MediaWiki's default diff colouration and formatting schema, brought in last week with the local deployment of 1.20wmf1. Predictably (see previous Signpost coverage), the result was much consternation and fierce debate (as of time of writing, it seems as though the new global default will remain the default on the English Wikipedia, albeit with possible tweaks).

Design controversy is nothing new to Wikimedia wikis, however. In May 2010, for example, an update to the famous Wikipedia "puzzle globe" logo caused pages of on- and off-wiki debate. Indeed, it was an episode that bore all the hallmarks of the present diff colour discussion: the change was primarily aimed at fixing an objective problem (incorrect characters) but also incorporated purely aesthetic changes, and hence sparked disagreement. In the end, the logo was adjusted slightly to respond to the criticism of it by Wikipedians, but the update was not reverted. It was around the same time that the Vector skin was rolled out – first optionally and then as the default for all users – prompting a similar number of complaints. These complaints included those of one user, still an active Wikimedia Commons editor, who wrote that "the kind of morons with no place whatsoever in Wikipedia ... I expect donations to plummet in reply to this change".

Not all central changes have stuck, either: the furore over a change to the colouring using in the new messages bar prompted it to be widely reverted. Of course, the correct analysis of this historical record is itself a controversial issue; commentators seem split between those who feel that controversy is a part of the design process that can't be eliminated and those who feel that it can be, but that developers and designers have never tried hard enough to eliminate it. One thing is certain, though: with design changes of some sort or another occurring on an increasingly rapid basis, it's rarely been a more topical issue.

In brief

Not all fixes may have gone live to WMF sites at the time of writing; some may not be scheduled to go live for many weeks.

At the time of this writing, 11 BRfAs are active. As always, community input is encouraged.

















Wikipedia:Wikipedia Signpost/2012-04-30/Technology_report